[PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver

Subsystems: hid core layer, the rest

STALE5685d

5 messages, 2 authors, 2011-02-16 · open the first message on its own page

[PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver

From: Benjamin Tissoires <hidden>
Date: 2011-02-15 14:33:57

Without this patch, the device is handled by hidinput and does
not have the right behavior.

Signed-off-by: Benjamin Tissoires <redacted>
---
Hi guys,

In the previous patch including the support to IRTOUCH devices, I forgot to add it to hid_have_special_driver. Sorry.

Cheers,
Benjamin

 drivers/hid/hid-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index d678cf3..a5f6439 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1345,6 +1345,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HANVON, USB_DEVICE_ID_HANVON_MULTITOUCH) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_IRTOUCHSYSTEMS, USB_DEVICE_ID_IRTOUCH_INFRARED_USB) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON, USB_DEVICE_ID_KS_SLIMBLADE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
-- 
1.7.4

Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver

From: Jiri Kosina <hidden>
Date: 2011-02-15 23:04:55

On Tue, 15 Feb 2011, Benjamin Tissoires wrote:
Without this patch, the device is handled by hidinput and does
not have the right behavior.

Signed-off-by: Benjamin Tissoires <redacted>
---
Hi guys,

In the previous patch including the support to IRTOUCH devices, I forgot 
to add it to hid_have_special_driver. Sorry.
Hmm, this happens quite often to people submitting patches, but I normally 
catch it. This time my eyes have failed.

Thanks for the fix, applied.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver

From: Benjamin Tissoires <hidden>
Date: 2011-02-16 09:54:29

Hi Jiri,

Thanks for applying those two patches.
BTW I'm a little worried: apparently you applied this patch in the
branch upstream-fixes but you didn't applied "HID: hid-multitouch:
introduce IrTouch Infrared USB..." and it's parents in this branch....
I'm afraid this will broke compilation of the upstream branch
(USB_VENDOR_ID_IRTOUCHSYSTEMS and USB_DEVICE_ID_IRTOUCH_INFRARED_USB
are not defined).

Thanks,
Benjamin

On Wed, Feb 16, 2011 at 00:04, Jiri Kosina [off-list ref] wrote:
On Tue, 15 Feb 2011, Benjamin Tissoires wrote:
quoted
Without this patch, the device is handled by hidinput and does
not have the right behavior.

Signed-off-by: Benjamin Tissoires <redacted>
---
Hi guys,

In the previous patch including the support to IRTOUCH devices, I forgot
to add it to hid_have_special_driver. Sorry.
Hmm, this happens quite often to people submitting patches, but I normally
catch it. This time my eyes have failed.

Thanks for the fix, applied.

--
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver

From: Jiri Kosina <hidden>
Date: 2011-02-16 17:38:19

On Wed, 16 Feb 2011, Benjamin Tissoires wrote:
Thanks for applying those two patches.
BTW I'm a little worried: apparently you applied this patch in the
branch upstream-fixes but you didn't applied "HID: hid-multitouch:
introduce IrTouch Infrared USB..." and it's parents in this branch....
I'm afraid this will broke compilation of the upstream branch
(USB_VENDOR_ID_IRTOUCHSYSTEMS and USB_DEVICE_ID_IRTOUCH_INFRARED_USB
are not defined).
Hi,

yes, I pushed the patch to wrong remote branch yesterday, but apparently 
sync to git.kernel.org in which I fixed it hasn't made it yet for some 
reason.

Sorry for the noise,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] HID: add IRTOUCH infrared USB to hid_have_special_driver

From: Benjamin Tissoires <hidden>
Date: 2011-02-16 17:54:59

On Wed, Feb 16, 2011 at 18:38, Jiri Kosina [off-list ref] wrote:
On Wed, 16 Feb 2011, Benjamin Tissoires wrote:
quoted
Thanks for applying those two patches.
BTW I'm a little worried: apparently you applied this patch in the
branch upstream-fixes but you didn't applied "HID: hid-multitouch:
introduce IrTouch Infrared USB..." and it's parents in this branch....
I'm afraid this will broke compilation of the upstream branch
(USB_VENDOR_ID_IRTOUCHSYSTEMS and USB_DEVICE_ID_IRTOUCH_INFRARED_USB
are not defined).
Hi,

yes, I pushed the patch to wrong remote branch yesterday, but apparently
sync to git.kernel.org in which I fixed it hasn't made it yet for some
reason.

Sorry for the noise,
No problem, and after all it was my fault at the beginning ;)

Thanks for taking care of this.

Cheers,
Benjamin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help