On Mon, Jan 24, 2011 at 02:48:04PM -0800, Andy Ross wrote:
Resubmission and update of the Pegatron Lucid tablet accelerometer and
ambient light sensor drivers.
Patches 1-3 are against asus-laptop, and apply in order.
Patch 4 is against input, and can be commited separately (obviously
relies on the detection code in asus-laptop at runtime, but will build
and load independently).
I am happy with the input part but I wonder if it really needs to be
separate? If you roll it up into asus-laptop you would not need a new
platform device and then it would be what - 20 lines of code?
Corentin, what do you think?
Thanks.
--
Dmitry
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
On Tue, Jan 25, 2011 at 12:05 AM, Dmitry Torokhov
[off-list ref] wrote:
On Mon, Jan 24, 2011 at 02:48:04PM -0800, Andy Ross wrote:
quoted
Resubmission and update of the Pegatron Lucid tablet accelerometer and
ambient light sensor drivers.
Patches 1-3 are against asus-laptop, and apply in order.
Patch 4 is against input, and can be commited separately (obviously
relies on the detection code in asus-laptop at runtime, but will build
and load independently).
I am happy with the input part but I wonder if it really needs to be
separate? If you roll it up into asus-laptop you would not need a new
platform device and then it would be what - 20 lines of code?
Corentin, what do you think?
I think that it should be consistent, if there is already some code
for pegatron tablet in asus-laptop, then why a new platform device
only for the accelerometer ?
On the other side, having to load "asus-laptop" on a pegatron tablet
(or on a lenovo laptop) isn't very intuitive.
The real name of this module should be atk010x_acpi, but it's not
really better, and it's probably too late for that.
Andy, what is shared with asus-laptop exactly ? What sysfs files are
working and enabled ?
Are backlight and led classes working ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
From: Andy Ross <hidden> Date: 2011-01-25 16:43:59
On 01/24/2011 11:30 PM, Corentin Chary wrote:
Dmitry Torokhov wrote:
quoted
I am happy with the input part but I wonder if it really needs to be
separate? If you roll it up into asus-laptop you would not need a new
platform device and then it would be what - 20 lines of code?
Corentin, what do you think?
I think that it should be consistent, if there is already some code
for pegatron tablet in asus-laptop, then why a new platform device
only for the accelerometer ?
No strong feelings here. I made it a separate file because
asus-laptop.c is already very large and this was something that could
be fairly easily split out, but obviously it's a really trivial
device.
Andy, what is shared with asus-laptop exactly ? What sysfs files are
working and enabled ? Are backlight and led classes working ?
Just the key device, which exports the single touch area in the corner
of the tablet as KEY_MEDIA. Some of the other sysfs devices
(bluetooth, display, leds) appear because the methods exist, but
they're stubbed out in the ASL and thus noops.
Andy
On Tue, Jan 25, 2011 at 4:43 PM, Andy Ross [off-list ref] wrote:
On 01/24/2011 11:30 PM, Corentin Chary wrote:
quoted
Dmitry Torokhov wrote:
quoted
I am happy with the input part but I wonder if it really needs to be
separate? If you roll it up into asus-laptop you would not need a new
platform device and then it would be what - 20 lines of code?
Corentin, what do you think?
I think that it should be consistent, if there is already some code
for pegatron tablet in asus-laptop, then why a new platform device
only for the accelerometer ?
No strong feelings here. I made it a separate file because
asus-laptop.c is already very large and this was something that could
be fairly easily split out, but obviously it's a really trivial
device.
quoted
Andy, what is shared with asus-laptop exactly ? What sysfs files are
working and enabled ? Are backlight and led classes working ?
Just the key device, which exports the single touch area in the corner
of the tablet as KEY_MEDIA. Some of the other sysfs devices
(bluetooth, display, leds) appear because the methods exist, but
they're stubbed out in the ASL and thus noops.
Andy
If everybody is ok with that, I think you should move the code back
into asus-laptop.c. But if you do so, don't forget to modify the help
text of ASUS_LAPTOP section in KConfig.
Should we also change the description to
"Asus/Medion/JVC/Lenovo/Pegatron Extra" ? That seems really ugly
but....
--
Corentin Chary
http://xf.iksaif.net
On Tue, Jan 25, 2011 at 05:05:05PM +0000, Corentin Chary wrote:
On Tue, Jan 25, 2011 at 4:43 PM, Andy Ross [off-list ref] wrote:
quoted
On 01/24/2011 11:30 PM, Corentin Chary wrote:
quoted
Dmitry Torokhov wrote:
quoted
I am happy with the input part but I wonder if it really needs to be
separate? If you roll it up into asus-laptop you would not need a new
platform device and then it would be what - 20 lines of code?
Corentin, what do you think?
I think that it should be consistent, if there is already some code
for pegatron tablet in asus-laptop, then why a new platform device
only for the accelerometer ?
No strong feelings here. I made it a separate file because
asus-laptop.c is already very large and this was something that could
be fairly easily split out, but obviously it's a really trivial
device.
quoted
Andy, what is shared with asus-laptop exactly ? What sysfs files are
working and enabled ? Are backlight and led classes working ?
Just the key device, which exports the single touch area in the corner
of the tablet as KEY_MEDIA. Some of the other sysfs devices
(bluetooth, display, leds) appear because the methods exist, but
they're stubbed out in the ASL and thus noops.
Andy
If everybody is ok with that, I think you should move the code back
into asus-laptop.c. But if you do so, don't forget to modify the help
text of ASUS_LAPTOP section in KConfig.
Should we also change the description to
"Asus/Medion/JVC/Lenovo/Pegatron Extra" ? That seems really ugly
but....
"Kitchen sink" so we do not need to adjust the description going
forward? ;P
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html