Thread (7 messages) flat view 7 messages, 3 authors, 2011-01-07

Re: [patch] input/tc3589x: fix compile error

From: Linus Walleij <hidden>
Date: 2011-01-05 10:55:37

2011/1/5 Dan Carpenter [off-list ref]:
On Wed, Jan 05, 2011 at 02:01:01AM +0100, Linus Walleij wrote:
quoted
2011/1/4 Dan Carpenter [off-list ref]:
quoted
There was a semi-colon missing and it broke the compile.
How come my setup compiles then... Oh well, probably a more
forgiving compiler.
The only explanation I can think of is that you're compiling the driver
into the kernel instead of as a module?
Yes that's it, hm the macro __MODULE_INFO() resolves to
nothing if compiled-in and resolves to something needing
a semicolon otherwise.

This makes some errors pass under the radar, looks
syntactically unsound to me :-(

I'll cook up a patch.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help