RE: [PATCH 1/1] input: tegra-kbc - Add tegra keyboard driver

Here are the list of changes. I was not sure of the protocol of adding this into the patch email.

a) Addressed all of Trilok Soni's comments excluding the tegra clk programming which is necessary.
Use correct labels in tegra_kbc_probe error paths. 
Identify and if necessary document all register accesses without using magic numbers.
Modify suspend to check for valid users before proceeding to close.
 
b) Removed the Fn keymap and its references. This obviated the need for some helper functions.

c) Setup the input device's keycodexx parameters.


Pavel's query

But now I'm confused; does hardware have Fx keys (F10 above) or not?
									Pavel

The function key for this keyboard is separate from the F1 to F12 keys, where the latter are always available.

The function key serves just like a SHIFT key to overload the use of certain keys e.g. Fn+PgUP-> "Home", Fn+PgDn -> "End"

Regards
Rakesh

-----Original Message-----
From: Pavel Machek [mailto:pavel@ucw.cz]
Sent: Wednesday, January 12, 2011 2:03 PM
To: Rakesh Iyer
Cc: tsoni@codeaurora.org; dmitry.torokhov@gmail.com; shubhrajyoti@ti.com;
ccross@android.com; konkers@android.com; olof@lixom.net; Andrew Chew; linux-
tegra@vger.kernel.org; linux-kernel@vger.kernel.org; linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1] input: tegra-kbc - Add tegra keyboard driver

On Wed 2011-01-12 13:59:45, Rakesh Iyer wrote:

quoted

Hi all.

I apologize for not specifying the PATCH indicator as "PATCH v4".

Sorry for the inconvenience caused.

Well, that is not huge problem, but short note of changes from last
version would be welcome.

AFAICT, FN handling was reworked...?

quoted

quoted

+     KEY_F10, KEY_F9, KEY_BACKSPACE, KEY_3,
+             KEY_2, KEY_UP, KEY_PRINT, KEY_PAUSE,

But now I'm confused; does hardware have Fx keys (F10 above) or not?
									Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html