Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver (fourth version)

On Mon, Jan 10, 2011 at 09:57:59AM +0100, Fabien Marteau wrote:

Hi Dmitry,

Thanks for the patch, I tested it on my platform and there is a little bug in irq request for the button :

+	error = request_threaded_irq(as5011->button_irq,
+				     NULL, as5011_button_interrupt,
+				     IRQF_TRIGGER_RISING | IRQF_TRIGGER_RISING,
+				     "as5011_button", as5011);

Should be :

+	error = request_threaded_irq(as5011->button_irq,
+				     NULL, as5011_button_interrupt,
+				     IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+				     "as5011_button", as5011);

With this modification the patch is ok.

Great, I applied it.

Thanks.

-- 
Dmitry