Re: [PATCH] Add support for the built-in digitizer in the Lenovo W700

Ping

Thank you for your support and encouragement, I have followed your
instructions and made a git patch for the kernel

I have not added any Acked-by line for this patch, I think you need to
do that? Please do the needful.


Thanks & best regards

Ajay

On Mon, Dec 20, 2010 at 10:10 AM, Ping Cheng [off-list ref] wrote:

On Sun, Dec 19, 2010 at 1:26 AM, Ajay Ramaswamy
[off-list ref] wrote:

quoted

Ping

Thanks for your support in getting this done. I have made a patch
against xf86-input-wacom master in git for Peter.

The patch looks good to me. I thought it would take sometime for you
to make a git patch since you mentioned that you have not programmed
in C for 20 years.

With your prompt reply, I think you can make a kernel patch just fine.
Please make your kernel patch based on the next branch of
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git and
submit it to linux-input@vger.kernel.org,

Thank you.

Ping

quoted

Hopefully all this will result in fedora 15 having support for my laptop.

Thanks & best regards

Ajay

On Sun, Dec 19, 2010 at 6:19 AM, Ping Cheng [off-list ref] wrote:

quoted

On Thu, Dec 16, 2010 at 6:37 AM, Ajay Ramaswamy [off-list ref] wrote:

quoted

Hello Ping Cheng

I have been using the tablet for the last 4 months without any
problems, Today I have updated my patches against the current
development series 0.10.10, can you accept these patches now?

The xf86-input-wacom looks fine. If you don't mind, please make a
patch in git format with my Acked-by tag so Peter can merge it to the
git repo.

I'll make a git patch based on your input-wacom-thinkpad-w700.patch
and submit it to linux-input on your behalf.

Thank you.

Ping

quoted

My request for testing has not got any response so far! Perhaps the
laptop is too exotic for it to be used widely by Linux users.

http://forums.lenovo.com/t5/W-Series-ThinkPad-Laptops/HELP-W700-color-calibration-or-finger-print-reader-and-tablet-in/m-p/211014#M7584

and

http://forum.thinkpads.com/viewtopic.php?f=48&t=89292&hilit=w700+wacom+linux

and

http://forums.fedoraforum.org/showthread.php?t=249263&highlight=w700+wacom


Thanks for your consideration.

with best regards
Ajay

On Tue, Jul 27, 2010 at 10:49 PM, Ping Cheng [off-list ref] wrote:

quoted

On Tue, Jul 27, 2010 at 5:22 AM, Ajay Ramaswamy [off-list ref] wrote:

quoted

On Tuesday 27 Jul 2010 12:03:38 pm Ping Cheng wrote:

quoted

quoted

quoted

I do have one question though: did you add LENOVO_VENDOR_ID and 0x6004
to the ignore list of hid-core.c in your kernel source?

NO, should I do that?

Oh, weird. If you didn't add it to the ignore list, it should be
grabbed by HID. That is Wacom driver can not take control of it. Maybe
the structure has been changed for your kernel version?

quoted

Like I said I haven't programmed in C for 20 years so
most of this is shooting in the dark.

I have also registered in a couple of Thinkpad forums and made a request
for testing of these patches, let us see if there is any response.

Good idea. I'll wait for the feedback.

Thank you.

Ping

[ajayr@kate by-id]$ ls -l /dev/input/by-id
total 0
lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Chicony_Electronics_Co.__Ltd._480c-
event-if00 -> ../event9
lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Logitech_USB_Gaming_Mouse-event-
mouse -> ../event5
lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Logitech_USB_Gaming_Mouse-mouse ->
../mouse1
lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Tablet_ISD-V4-event-mouse ->
../event6
lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Tablet_ISD-V4-mouse -> ../mouse2
[ajayr@kate by-id]$


is this expected? should the tablet show both as mouse and event?

Those are fine.

quoted

shall I rebuild a kernel with a patch to ignore the LENOVO 0x6004 device like this?

Since the tablet works for you, I would think you don't need the
change. However, I would also eager to know if there would be any
difference in the behaviour of the tablet if you apply the patch.
Please make sure you are adding the line to ignorelist instead of
blacklist (I do not have the source to diff it).

Thank you.

Ping