Thread (16 messages) 16 messages, 3 authors, 2010-11-18

Re: [PATCH 1/5] qt602240_ts: fix wrong sizeof in object table allocation

From: Joonyoung Shim <hidden>
Date: 2010-11-18 11:31:20

On 2010-11-18 오후 8:16, Joonyoung Shim wrote:
Hi, Chris.

On 2010-11-17 오전 5:41, Chris Leech wrote:
quoted
The kcalloc call for the object table is using sizeof(struct
qt602240_data)
when it should be using sizeof(struct qt6602240_object), resulting in
a larger
allocation than is required.

Signed-off-by: Chris Leech<redacted>
Acked-by: Joonyoung Shim <redacted>
Wrong e-mail address.

Acked-by: Joonyoung Shim <redacted>
Thanks.
quoted
---
drivers/input/touchscreen/qt602240_ts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/qt602240_ts.c
b/drivers/input/touchscreen/qt602240_ts.c
index 66b26ad..0b92c9d 100644
--- a/drivers/input/touchscreen/qt602240_ts.c
+++ b/drivers/input/touchscreen/qt602240_ts.c
@@ -969,7 +969,7 @@ static int qt602240_initialize(struct
qt602240_data *data)
return error;

data->object_table = kcalloc(info->object_num,
- sizeof(struct qt602240_data),
+ sizeof(struct qt602240_object),
GFP_KERNEL);
if (!data->object_table) {
dev_err(&client->dev, "Failed to allocate memory\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help