Thread (10 messages) flat view 10 messages, 4 authors, 2010-10-23

Re: [PATCH 1/3] IR: extend ir_raw_event and do refactoring

From: David Härdeman <david@hardeman.nu>
Date: 2010-10-23 12:13:34
Also in: linux-media

On Sun, Oct 17, 2010 at 12:56:28AM +0200, Maxim Levitsky wrote:
Add new event types for timeout & carrier report
Move timeout handling from ir_raw_event_store_with_filter to
ir-lirc-codec, where it is really needed.
Now lirc bridge ensures proper gap handling.
Extend lirc bridge for carrier & timeout reports

Note: all new ir_raw_event variables now should be initialized
like that: DEFINE_IR_RAW_EVENT(ev);

To clean an existing event, use init_ir_raw_event(&ev);

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Acked-by: Jarod Wilson <redacted>
I finally had a read-through of this patch. I like it. Note that we're 
going to have to change the decoders to also use the timeout event 
(since it basically behaves like a long space and e.g. the NEC decoder 
waits for the trailing space before sending a keydown). The same problem 
already exists for users of ir_raw_event_store_with_filter() though so 
the patch should still go in.

Acked-by: David Härdeman <david@hardeman.nu>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help