Thread (3 messages) 3 messages, 2 authors, 2010-09-23

RE: [PATCHv3] input: ROHM BU21013 touch panel controller support

From: Naveen Kumar GADDIPATI <hidden>
Date: 2010-09-23 06:10:29

Hi Henrik,

Thanks for your comments.
-----Original Message-----
From: Henrik Rydberg [mailto:rydberg@euromail.se]
Sent: Wednesday, September 22, 2010 11:51 PM
quoted
+struct bu21013_ts_data {
+	struct i2c_client *client;
+	wait_queue_head_t wait;
+	bool touch_stopped;
+	const struct bu21013_platform_device *chip;
+	struct input_dev *in_dev;
+	unsigned int intr_pin;
+	signed short	x_pos[2];
+	signed short	y_pos[2];
+	bool previous_press_reported;

The MT state here (x_pos, y_pos, previous_press_reported) could, in
principle,
be simplified away, since the type A protocol is stateless.

[...]
	What is type A protocol? Could you elaborate.
quoted
+static int bu21013_do_touch_report(struct bu21013_ts_data *data)
quoted
+	if (((number_of_active_x_sensors != 0) &&
+		(number_of_active_y_sensors == 0)) ||
+		((number_of_active_x_sensors == 0) &&
+		(number_of_active_y_sensors != 0)))
+		return 0;

So these should really be completely ignored, not reported as touch up?
Any
chance the above is the last event seen before a period of no activity?
	This is the case one of x or y sensors is 0(when touch is not recognized properly),
	this should be ignored.
 
Thanks & Regards,
Naveen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help