On 9/9/2010 6:50 PM, Naveen Kumar GADDIPATI wrote:

Hi Trilok,

quoted

-----Original Message-----
From: Trilok Soni [mailto:tsoni@codeaurora.org]
Sent: Thursday, September 09, 2010 5:41 PM
To: Naveen Kumar GADDIPATI
Cc: Dmitry Torokhov; linux-input@vger.kernel.org;
STEricsson_nomadik_linux

quoted

quoted

+
+static struct i2c_driver bu21013_driver = {
+       .driver = {
+               .name   =       DRIVER_TP,
+               .owner  =       THIS_MODULE,
+       },
+       .probe          =       bu21013_probe,
+#ifdef CONFIG_PM
+       .suspend        =       bu21013_suspend,
+       .resume         =       bu21013_resume,
+#endif

Better to move these suspend and resume to dev_pm_ops.

	How we could dev_pm_ops in i2c driver structure?

Refer: drivers/input/keyboard/adp5588-keys.c as example.

---Trilok Soni
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.