Re: [PATCH 2/2] hid/hid-sony: get and set Sixaxis bdaddr via sysfs

On Wed, 2010-09-01 at 19:28 +0200, Antonio Ospite wrote:

On Wed, 01 Sep 2010 17:17:54 +0100
Bastien Nocera [off-list ref] wrote:

quoted

On Mon, 2010-05-03 at 22:15 +0200, Antonio Ospite wrote:

quoted

Expose to userspace a simple way to get device bdaddr, and get/set master
bdaddr on Sixaxis controller.

Right now userspace softwares which manage pairing the controller with a
bluetooth adapter, rely on libusb and hence have to detach and reattach
usbhid, which is not very nice.

Signed-off-by: Antonio Ospite <redacted>
---

As said, ideally this should be done with an interface such as hidraw, but its
limitations prevent us from doing it the right way; and I am not going to
touch hidraw myself anytime soon.

Rest looks alright to me. Thanks!

Bastien, Jiri, this patch can be DISCARDED. The hidraw work from Alan
Ott (waiting for Marcel to ACK the bluetooth part) will make this kernel
approach overkill.

I already have some bluez patches based on Alan's work, but I am waiting
for the needed changes to land into linus tree before submitting them.

Sorry for making you wasting some time reviewing this one, I told you on
IRC it could be discarded, but we know: "IRCs volant, emails manent".

Given the time it took me to review it, it's my own damn fault anyway ;)