Re: [PATCH] HID: wake up reading tasks when debug event occurs
From: Jiri Kosina <hidden>
Date: 2010-09-08 10:03:21
Also in:
lkml
On Mon, 30 Aug 2010, Chase Douglas wrote:
From: Chase Douglas <redacted> Some devices poke the hid core in a way that causes hid_debug_event to be called, while never calling hid_dump_input. Without this wakeup addition, tasks reading for hid events through debugfs may never see any events. It may be that a well written driver doesn't cause this, but then what's the point of debugfs?
Well the main reason for the debugfs interface has been to debug strange devices. But your fix is a clear improvement for pathological cases, which is OK for debugging interface. Applied, thanks.
quoted hunk ↗ jump to hunk
Signed-off-by: Chase Douglas <redacted> --- drivers/hid/hid-debug.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index 850d02a..adff4ef 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c@@ -570,6 +570,8 @@ void hid_debug_event(struct hid_device *hdev, char *buf) buf[i]; list->tail = (list->tail + i) % HID_DEBUG_BUFSIZE; } + + wake_up_interruptible(&hdev->debug_wait); } EXPORT_SYMBOL_GPL(hid_debug_event);-- 1.7.1
-- Jiri Kosina SUSE Labs, Novell Inc.