Re: [PATCH] identify firmware version

On 09/07/2010 01:32 AM, Rafi Rubin wrote:

On Mon, Sep 06, 2010 at 11:22:50PM +0200, Jiri Slaby wrote:

quoted

quoted

quoted

+
+		ret = ntrig_version_string(&data[2], buf);
+
+		dev_info(&hdev->dev,
+			 "Firmware version: %s (%02x%02x %02x%02x)\n",
+			 buf, data[2], data[3], data[4], data[5]);
+
+		kfree(buff);

In any case, this doesn't compile...

quoted

quoted

+	}

Jiri, I moved the code to a separate function as Dmitry suggested, and compiled a kernel from a clean tree using 
gcc-3.4 (I think).

This version is OK. In the previous one, there was
char *buf;
...
kfree(buff);

thanks,
-- 
js