Re: [PATCH 1/1] usbhid: Set Report ID properly for Output reports on the Control endpoint.
From: Sergei Shtylyov <hidden>
Date: 2010-08-25 09:49:48
Also in:
lkml
Hello. Alan Ott wrote:
When I made commit 29129a98e6fc89, I didn't account for *buf not being the report ID anymore, as buf is incremented.
This applies to 2.6.35 and newer.
Signed-off-by: Alan Ott <redacted>
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index b729c02..ffd6899 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c@@ -828,6 +828,7 @@ static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t co } } else { int skipped_report_id = 0; + int report_id = buf[0];
Please keep the empty line after the declaration block.
if (buf[0] == 0x0) {
/* Don't send the Report ID */
buf++;WBR, Sergei