Hi Henrik,

-----Original Message-----
From: Henrik Rydberg [mailto:rydberg@euromail.se]
Sent: Monday, July 12, 2010 11:48 PM
To: Kevin McNeely
Cc: Dmitry Torokhov; David Brown; Trilok Soni; Fred; Samuel Ortiz;

Eric

Miao; Mark Brown; Simtec Linux Team; Arnaud Patard; Antonio Ospite;
linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: cyttsp i2c touchscreen driver init submit

Kevin McNeely wrote:

quoted

From: Fred <redacted>

This is a new touchscreen driver for the Cypress Semiconductor
cyttsp family of devices.  This driver is for the i2c version
of cyttsp parts.

Signed-off-by: Kevin McNeely <redacted>
---

This driver contains too much code. I am wondering if the device
actually
supports tracking id, or whether it is emulated in the driver code? If
tracking
is not well supported in hardware, then please use MT protocol A and
remove the
usage of ABS_MT_TRACKING_ID and the logic around it. If tracking is
indeed well
supported in the hardware, then please use MT protocol B.

Thanks,
Henrik

I have a new code set that has been refactored and easier to follow.
The driver supports both Protocol A and Protocol B.
The Cypress TTSP parts have well supported Tracking ID's, so the driver
provides protocol B reporting option.
The driver also handles reporting without the Tracking ID's for Protocol
A option.
A user selects which option in the board configuration file.

Thank you Henrik for your review.



---------------------------------------------------------------
This message and any attachments may contain Cypress (or its
subsidiaries) confidential information. If it has been received
in error, please advise the sender and immediately delete this
message.
---------------------------------------------------------------