Re: [PATCH 2.6.37? ] drivers/input: Use pr_<level>

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2010-08-04 08:04:14
Also in
lkml
Reply to
Joe Perches, 2010-08-04
On Wed, Aug 04, 2010 at 12:33:42AM -0700, Joe Perches wrote:
On Tue, 2010-08-03 at 21:32 -0700, Dmitry Torokhov wrote:
quoted
Hi Joe,
Hi Dmitry.
quoted
On Tue, Aug 03, 2010 at 11:40:50AM -0700, Joe Perches wrote:
quoted
Remove prefixes from printks and convert to pr_fmt/pr_<level>.
Thanks for doing this, however instead of using pr_xxx() I'd like
drivers that are integrated in driver model (serio, usb, gameport, etc,
i.e. when we have 'struct device' available, exept for psmouse) to use
drv_xxx() instead.
These files?
$ grep -rPl --include=*.[ch] "\bstruct\s+device\b" drivers/input | \
  xargs grep -wl pr_fmt
drivers/input/keyboard/omap-keypad.c
drivers/input/mousedev.c
drivers/input/serio/serio.c
drivers/input/serio/i8042.c
drivers/input/evdev.c
drivers/input/joydev.c
drivers/input/gameport/gameport.c
drivers/input/touchscreen/htcpen.c
drivers/input/input-polldev.c
drivers/input/input.c
drivers/input/tablet/aiptek.c
drivers/input/misc/winbond-cir.c
drivers/input/misc/yealink.c
drivers/input/misc/ati_remote2.c
drivers/input/misc/wistron_btns.c
drivers/input/misc/ati_remote.c
drivers/input/mouse/psmouse-base.c
There should be more. USB for example. Basically anything but very old
legacy drivers that never been converted to the 2.6 device model.
  
quoted
That would make synaptics messages to come as "psmouse", right?
Yes.
quoted
I think we should use
	#define pr_fmt(fmt) "synaptics: " fmt
here and in the rest of specialized PS/2 protocol handlers.
Perhaps convert to what elantech uses
#define pr_fmt(fmt) KBUILD_BASENAME ": " fmt

$ grep -l "define pr_fmt" drivers/input/mouse/*.[ch] | \
  xargs grep -il "ps2" 
drivers/input/mouse/alps.c
drivers/input/mouse/elantech.c
drivers/input/mouse/lifebook.c
drivers/input/mouse/logips2pp.c
drivers/input/mouse/psmouse-base.c
psmouse-base should use KBUILD_MODNAME, for the rest of these
KBUILD_BASENAME seems to fit.
drivers/input/mouse/sentelic.c
drivers/input/mouse/synaptics.c
drivers/input/mouse/trackpoint.c

Which ones do you want converted? 
Any others?
No, I think this is it as far as PS/2 mice go.

-- 
Dmitry
Thread (16 messages) 16 messages, 2 authors, last reply 2010-08-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help