Re: [PATCH 06/13] IR: nec decoder: fix repeat.
From: Andy Walls <awalls@md.metrocast.net>
Date: 2010-07-30 02:49:44
Also in:
linux-media
On Fri, 2010-07-30 at 05:17 +0300, Maxim Levitsky wrote:
Repeat space is 4 units, not 8. Current code would never trigger a repeat.
Yup. Page 11, line (4) http://www.datasheetcatalog.org/datasheet/nec/UPD6122G-002.pdf Reviewed-by: Andy Walls <awalls@md.metrocast.net> Regards, Andy
quoted hunk ↗ jump to hunk
However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com> --- drivers/media/IR/ir-nec-decoder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec-decoder.c index 52e0f37..1c0cf03 100644 --- a/drivers/media/IR/ir-nec-decoder.c +++ b/drivers/media/IR/ir-nec-decoder.c@@ -20,7 +20,7 @@ #define NEC_HEADER_PULSE (16 * NEC_UNIT) #define NECX_HEADER_PULSE (8 * NEC_UNIT) /* Less common NEC variant */ #define NEC_HEADER_SPACE (8 * NEC_UNIT) -#define NEC_REPEAT_SPACE (8 * NEC_UNIT) +#define NEC_REPEAT_SPACE (4 * NEC_UNIT) #define NEC_BIT_PULSE (1 * NEC_UNIT) #define NEC_BIT_0_SPACE (1 * NEC_UNIT) #define NEC_BIT_1_SPACE (3 * NEC_UNIT)