Re: [PATCH 2/3] usbtouchscreen: Implement runtime power management

On Mon, 7 Jun 2010, Oliver Neukum wrote:

Am Montag, 7. Juni 2010 18:23:16 schrieb Dmitry Torokhov:

quoted

On Mon, Jun 07, 2010 at 03:13:42PM +0200, Oliver Neukum wrote:

quoted

 static int usbtouch_open(struct input_dev *input)
 {
 	struct usbtouch_usb *usbtouch = input_get_drvdata(input);
+	int r;
 
 	usbtouch->irq->dev = interface_to_usbdev(usbtouch->interface);
 
+	r = usb_autopm_get_interface(usbtouch->interface) ? -EIO : 0;

Why are we clobbering error code with -EIO? We should propagate te code
returned to us (here and below).

usb_autopm_get_interface() uses internal USB error codes which with
a few exceptions, do not have the meaning error codes in user space
have.

But other drivers don't do this.  What's special about usbtouch?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html