Re: [RFC] [PATCH v3 1/4] OMAP4: Keyboard controller support
From: Kevin Hilman <hidden>
Date: 2010-06-01 17:46:01
Also in:
linux-omap
"Arce, Abraham" [off-list ref] writes:
quoted hunk
OMAP4 keyboard controller includes: - built-in scanning algorithm - debouncing feature Driver implementation is based on matrix_keypac.c Signed-off-by: Syed Rafiuddin <redacted> Signed-off-by: Abraham Arce <redacted> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- arch/arm/plat-omap/include/plat/omap4-keypad.h | 23 ++ drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/omap4-keypad.c | 288 ++++++++++++++++++++++++ 4 files changed, 322 insertions(+), 0 deletions(-) create mode 100644 arch/arm/plat-omap/include/plat/omap4-keypad.h create mode 100644 drivers/input/keyboard/omap4-keypad.cdiff --git a/arch/arm/plat-omap/include/plat/omap4-keypad.h b/arch/arm/plat-omap/include/plat/omap4-keypad.h new file mode 100644 index 0000000..7a6ce70 --- /dev/null +++ b/arch/arm/plat-omap/include/plat/omap4-keypad.h@@ -0,0 +1,23 @@ +#ifndef ARCH_ARM_PLAT_OMAP4_KEYPAD_H +#define ARCH_ARM_PLAT_OMAP4_KEYPAD_H + +#include <linux/input/matrix_keypad.h> + +struct omap4_keypad_platform_data { + const struct matrix_keymap_data *keymap_data; + + u8 rows; + u8 cols; + + u16 irq; + void __iomem *base; + + int (*device_enable) (struct platform_device *pdev); + int (*device_shutdown) (struct platform_device *pdev); + int (*device_idle) (struct platform_device *pdev); +};
Abraham, Please drop these from this driver. First, they are not used in the driver, and 2nd, new drivers should use the runtime PM API for this as needed. Kevin