RE: [PATCH] HID: Add support to new N-trig firwmare

Hi rafi
Thank for the remarks
Before submitting the patch I used checkpatch.pl script
And checked whitespace in the code I inserted. 
Yes I aware there is no product id 0x002. (it's ok)
Micki


-----Original Message-----
From: Rafi Rubin [mailto:rafi@seas.upenn.edu] 
Sent: Monday, June 21, 2010 9:15 AM
To: Micki Balanga
Cc: Jiri Kosina; chatty@enac.fr; dhprince-devel@yahoo.co.uk;
linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: Add support to new N-trig firwmare

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/21/10 01:06, Micki Balanga wrote:

Hi Jiri
We have some new product so I have to update the patch,
When I update my git branch I didn't see the changes regarding N-trig
Product id. If you can insert this patch, if there a problem with the
patch
Let me know and hi will update it
Thank you
Micki


-----Original Message-----
From: Jiri Kosina [mailto:jkosina@suse.cz] 
Sent: Saturday, June 05, 2010 6:42 PM
To: Micki Balanga
Cc: chatty@enac.fr; dhprince-devel@yahoo.co.uk;
linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Rafi Rubin
Subject: RE: [PATCH] HID: Add support to new N-trig firwmare

On Fri, 4 Jun 2010, Micki Balanga wrote:

quoted

Hi Jiri,
Attach the patch via file.
(Also fix 3 warning: please , no space before tabs)

Thanks Micki, I have applied the patch.

Micki, looks like there are a couple of accidental whitespace
modifications:

- -#define USB_VENDOR_ID_ADS_TECH                 0x06e1
+#define USB_VENDOR_ID_ADS_TECH 0x06e1

- -#define USB_VENDOR_ID_EZKEY            0x0518
+#define USB_VENDOR_ID_EZKEY            0x0518


Also, in the list of product ids, did you mean to skip 2?


Jiri, is there a better way than listing each device individually?


Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwfA0UACgkQwuRiAT9o60+M9QCfQJcJ7pMo9TOY5vYgfK6Yq16d
nD8AoK+l5sVJKAUEpyYEEANnCFCNm/zr
=IFqR
-----END PGP SIGNATURE-----