[PATCH] HID: Fixing offset errors in bin_attribute read functions of roccat kone

Subsystems: hid core layer, roccat drivers, the rest

STALE5887d

2 messages, 2 authors, 2010-06-21 · open the first message on its own page

[PATCH] HID: Fixing offset errors in bin_attribute read functions of roccat kone

From: Stefan Achatz <erazor_de@users.sourceforge.net>
Date: 2010-06-20 17:19:14

Fixing wrong calculated offsets in bin_attribute read functions.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
---
 drivers/hid/hid-roccat-kone.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
index fcc2ccc..f776957 100644
--- a/drivers/hid/hid-roccat-kone.c
+++ b/drivers/hid/hid-roccat-kone.c
@@ -272,7 +272,7 @@ static ssize_t kone_sysfs_read_settings(struct file *fp, struct kobject *kobj,
 		count = sizeof(struct kone_settings) - off;
 
 	mutex_lock(&kone->kone_lock);
-	memcpy(buf, &kone->settings + off, count);
+	memcpy(buf, ((char const *)&kone->settings) + off, count);
 	mutex_unlock(&kone->kone_lock);
 
 	return count;
@@ -332,7 +332,7 @@ static ssize_t kone_sysfs_read_profilex(struct kobject *kobj,
 		count = sizeof(struct kone_profile) - off;
 
 	mutex_lock(&kone->kone_lock);
-	memcpy(buf, &kone->profiles[number - 1], sizeof(struct kone_profile));
+	memcpy(buf, ((char const *)&kone->profiles[number - 1]) + off, count);
 	mutex_unlock(&kone->kone_lock);
 
 	return count;
-- 
1.6.6.1


Re: [PATCH] HID: Fixing offset errors in bin_attribute read functions of roccat kone

From: Jiri Kosina <hidden>
Date: 2010-06-21 12:05:09

On Sun, 20 Jun 2010, Stefan Achatz wrote:
Fixing wrong calculated offsets in bin_attribute read functions.
Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help