Re: [PATCH] HID: TWL4030: add HID Force Feedback vibra
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2010-02-20 08:52:33
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2010-02-20 08:52:33
On Thu, Feb 18, 2010 at 02:50:16PM +0200, Jari Vanhala wrote:
On Wed, 2010-02-17 at 13:41 +0100, ext Jiri Kosina wrote:quoted
On Wed, 17 Feb 2010, Jari Vanhala wrote: As the device doesn't seem to be registering itself on the HID bus at all, I am not sure we want to put it together with all the HID drivers. Maybe drivers/input/misc would be more appropriate?I felt like I forgot something.. Well, moving it to input/misc is easy (commit attached), but I (still) wanted to try getting it to use hid-functions. Results weren't that nice. Looking hid-core just shows, it's thought to connect (hotplug) usb or bt devices and i2c doesn't fit nicely to that. Making it to use hid_allocate_device(), hid_connect() etc takes actually more code.. Leaving it as-is in hid would look little odd, so probably moving it to drivers/input/misc is best thing. What you think? Dmitry?
I can take it into misc. Still need to review it though. -- Dmitry