Thread (5 messages) 5 messages, 4 authors, 2010-02-25

Re: [PATCH v2] Input: ads7846: add regulator support

From: Mark Brown <hidden>
Date: 2010-02-13 19:52:10
Also in: linux-omap

On Sat, Feb 13, 2010 at 09:40:26PM +0200, Mike Rapoport wrote:
On Sat, Feb 13, 2010 at 6:31 PM, Grazvydas Ignotas [off-list ref] wrote:
quoted
+       ts->reg = regulator_get(&spi->dev, "vcc");
"vcc" is way too generic name. What about "vcc-ts" or "vcc-touch"?
This should be OK as-is - the general style for regulators is to use
whatever the name the datasheet gives to the supply.  The string used
is namespaced using the supplied struct device and isn't connected to
the strings used to name the regulator providing the supply so there
should be no cause for name collisions.

Only supplies for things like CPUs which don't currently have struct
devices associated with them have issues with name collisions.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help