Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel
From: Jiri Kosina <hidden>
Date: 2010-02-09 10:27:02
On Sat, 6 Feb 2010, Stephane Chatty wrote:
Fixed bug in touchscreen emulation for the Stantum multitouch panel
Hi Stephane, could you please perhaps provide a little bit more detailed information about the nature of the bug this is fixing? It might be useful for people looking through changelog.
quoted hunk ↗ jump to hunk
Signed-off-by: Stephane Chatty <redacted> diff -rupN a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c--- a/drivers/hid/hid-stantum.c 2010-02-06 14:59:57.000000000 +0100 +++ b/drivers/hid/hid-stantum.c 2010-02-06 15:00:36.000000000 +0100@@ -16,7 +16,7 @@ #include <linux/hid.h> #include <linux/module.h> -MODULE_VERSION("1.00"); +MODULE_VERSION("1.01");
Are you planning to maintain this numbering, btw? Usually people forget to update it :)
quoted hunk ↗ jump to hunk
MODULE_AUTHOR("Stephane Chatty [off-list ref]"); MODULE_DESCRIPTION("Stantum HID multitouch panels"); MODULE_LICENSE("GPL");@@ -147,7 +147,6 @@ static void stantum_filter_event(struct input_mt_sync(input); sd->valid = false; - sd->first = false; /* touchscreen emulation */ if (sd->first) {@@ -158,6 +157,7 @@ static void stantum_filter_event(struct input_event(input, EV_ABS, ABS_X, sd->x); input_event(input, EV_ABS, ABS_Y, sd->y); } + sd->first = false; }
Thanks, -- Jiri Kosina SUSE Labs, Novell Inc.