Thread (19 messages) 19 messages, 7 authors, 2010-02-08

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

From: Mauro Carvalho Chehab <hidden>
Date: 2010-02-04 14:06:30
Also in: linux-media, lkml

Jiri Slaby wrote:
On 02/04/2010 02:41 PM, Mauro Carvalho Chehab wrote:
quoted
The point is that it is better to name the function right since the beginning.
Sorry, I misunderstood you for the first time. It's .event member of
hid_driver. Hence I named it dvb_event (or now rc_event or whatever).

The function may contain decisions on what to do with the event based
for example on quirks set up in .probe. And if the function grows later,
it may be factored out to rc_nokeyup_event. But rc_event is a root for
the decision tree and it should be there forever. Does it make sense now?
Ah, ok. Due to the comments at the function, I misunderstood that you were
planning to have separate functions for separate quirks.


-- 

Cheers,
Mauro
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help