Re: [PATCH 5/7] Input: wacom - Convert remaining ids, part two

Jason,

On Wed, Feb 03, 2010 at 09:34:09AM -0500, Jason Childs wrote:

Dmitry,

I actually responded on this issue to Ping last night.  My argument is that
the usb_driver structure is subject to revision on a per kernel basis and
should be in wacom_sys.c.

100% agree, and that is why usb_driver continues to stay in wacom_sys.
Wacom product IDs however are hardly linux-specific, usb_device_id is
unlikely to be changed significantly (since there are userspace ties)
and thus make sense to be kept in wacom_wac.c

 Also with the new set of bamboo patches the
features structures are copied per device instance during the initial probe
so we are not breaking static conventions.

Ah, great. So nothing stops you guys from marking these statics const - I
can't do it till your changes reach me. Speaking of which, the next
merge window is getting close so now would be the best time to send your
pending queue towars me. *wink, wink*

Thanks.

-- 
Dmitry