Re: [PATCH] Input: add appleir USB driver
From: Jiri Kosina <hidden>
Date: 2010-01-27 15:40:05
On Wed, 20 Jan 2010, Bastien Nocera wrote:
+First, you will need to disable the kernel driver for the receiver. + +This can be achieved by passing quirks to the usbhid driver. +The quirk line would be: +usbhid.quirks=0x05ac:0x8242:0x08 + +With 0x05ac being the vendor ID (Apple, you shouldn't need to change this) +With 0x8242 being the product ID (check the output of lsusb for your hardware) +And 0x08 being "HID_CONNECT_HIDDEV"
I am afraid this is not true, 0x08 is HID_QUIRK_NOGET. We currently don't have dynamic quirk for forcing HIDDEV creation from the module parameter.
+ if (!memcmp(data, keydown, sizeof(keydown))) {
+ /*If we already have a key down, take it up before marking */
+ /*this one down */
+ if (appleir->current_key)
+ key_up(appleir, appleir->current_key);
+ appleir->current_key = keymap[(data[4] >> 1) & MAX_KEYS_MASK];
+
+ key_down(appleir, appleir->current_key);
+ /*remote doesn't do key up, either pull them up, in the test */
+ /*above, or here set a timer which pulls them up after 1/8 s */Could you please place spaces after the comment starters? Thanks, -- Jiri Kosina SUSE Labs, Novell Inc.