Re: [patch 1/1] hid: Logitech G13 driver 0.0.2
From: Jiri Kosina <hidden>
Date: 2009-12-22 23:57:46
On Mon, 21 Dec 2009, akpm@linux-foundation.org wrote:
From: "Rick L. Vinyard Jr." <redacted> This is a driver for the Logitech G13 gamepad, and contains three key parts. In the USB reports the device identifies itself as a HID, and as a result this driver is under the HID framework. There are two primary sub-components to this driver; an input device and a framebuffer device. Although identified as a HID, the device does not support standard HID input messages. As a result, a sub-input device is allocated and registered separately in g13_probe(). The raw events are monitored and key presses/joystick activity is reported through the input device after referencing an indexed keymap. Additionally, this device contains a 160x43 monochrome LCD display. A registered framebuffer device manages this display. The design of this portion of the driver was based on the design of the hecubafb driver with deferred framebuffer I/O since there is no real memory to map. Signed-off-by: Rick L. Vinyard, Jr <redacted> Cc: Oliver Neukum <oliver@neukum.org> Cc: Dmitry Torokhov <redacted> Cc: Jiri Kosina <redacted> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
The driver doesn't build for me. Seems like missing some framebuffer-related include at a first glance. Rick, care to fix that up please? drivers/hid/hid-g13.c:121: error: field ‘fb_defio’ has incomplete type drivers/hid/hid-g13.c:1207: error: variable ‘g13_fb_defio’ has initializerbut incomplete type drivers/hid/hid-g13.c:1208: error: unknown field ‘delay’ specified ininitializer drivers/hid/hid-g13.c:1208: warning: excess elements in struct initializer drivers/hid/hid-g13.c:1208: warning: (near initialization for ‘g13_fb_defio’) drivers/hid/hid-g13.c:1209: error: unknown field ‘deferred_io’ specified in initializer drivers/hid/hid-g13.c:1209: warning: excess elements in struct initializer drivers/hid/hid-g13.c:1209: warning: (near initialization for ‘g13_fb_defio’) drivers/hid/hid-g13.c: In function ‘g13_probe’:drivers/hid/hid-g13.c:1351: error: ‘struct fb_info’ has no member named ‘fbdefio’ Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html