On Thu, 10 Dec 2009, Gary Stein wrote:

This is a cleaned up and updated driver for the G940.  I followed most 
of the checkpatch notes except for some of the 80 column stuff, the 
sections of where most of that code is hid-core.c also doesn't seem to 
care about it.

Yup, that's OK, thanks.

Please also fix up a few comments on various places which are wrongly 
intended, such as

+       /* maxusage should be 63, maximum fields
+               likely a better way to ensure this data is clean */

which should rather be in a format more similar to

	/* 
	 * first comment line
	 * second comment line
	 */

However, also in this code is the (int) cast fix that I send before to 
linux-kernel in ff-memless.  Without this, my driver or the normal 
logitech driver for other sticks seems to work for me.

Dmitry, will you pick that one up for your tree? 

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.