On Sat, 2009-11-28 at 21:35 -0800, Dmitry Torokhov wrote:

On Sat, Nov 28, 2009 at 09:44:41PM +0800, Wu Zhangjin wrote:

quoted

 
+config YEELOONG_HOTKEY
+	tristate "Hotkey Driver"
+	depends on YEELOONG_VO
+	select INPUT

I think this should be depend, not select. 

Hmm, okay, will replace it by depend later ;)

quoted

+	select INPUT_EVDEV
+	select SUSPEND

Does it break without SUSPEND?

not break, but I just want to select something for users, so, they will
have no need to care about which extra option is needed.

anyway, I will use #ifdef ... #endif instead later.

 I am pretty sure that it will work fine
without EVDEV (however unlikely it is not present).

Yes, without EVDEV, it can be compiled, but without the EVDEV module, no
event will be sent to the user-space, as a result, we just get a broken
input support. so, let the users make their decision?

Regards,
	Wu Zhangjin