Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags
From: Ferenc Wagner <hidden>
Date: 2009-11-23 16:42:17
Possibly related (same subject, not in this thread)
- 2009-11-29 · Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags · Ferenc Wagner <hidden>
- 2009-11-28 · Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags · Mika Westerberg <hidden>
- 2009-11-28 · Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags · Ferenc Wagner <hidden>
- 2009-11-27 · Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags · Mika Westerberg <hidden>
- 2009-11-26 · Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags · Dmitry Torokhov <dmitry.torokhov@gmail.com>
Mika Westerberg [off-list ref] writes:
quoted hunk
Added new field to struct gpio_keys_button: irqflags which can be used to specify exact irqflags the platform wants. If not specified, it defaults to: IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING.--- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c@@ -106,10 +107,14 @@ static int __devinit gpio_keys_setup_key(struct device *dev, goto fail3; } - error = request_irq(irq, gpio_keys_isr, - IRQF_SHARED | - IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, - desc, bdata); + if (button->irqflags == 0) { + irqflags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | + IRQF_SHARED; + } else { + irqflags = button->irqflags; + } + + error = request_irq(irq, gpio_keys_isr, irqflags, desc, bdata); if (error) { dev_err(dev, "Unable to claim irq %d; error %d\n", irq, error);
Hi Mika,
linux/interrupt.h says:
When requesting an interrupt without specifying a IRQF_TRIGGER, the
setting should be assumed to be "as already configured", which may
be as per machine or firmware initialisation.
So I'm not sure it's a good idea to exclude 0 from the possible irqflag
values.
--
Regards,
Feri.