Re: [PATCH 1/2] Input: gpio-keys: allow drivers to specify whether IRQ can be shared
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2009-11-20 08:38:15
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2009-11-20 08:38:15
Hi Mika, On Thu, Nov 19, 2009 at 09:23:45AM +0200, Mika Westerberg wrote:
Added new field to struct gpio_keys_button: exclusive_irq which can be used to specify whether driver wants to have exclusive access to IRQ or can it be shared. By default IRQs for gpio-keys are shareable.
I think the idea makes sense with one exception - why limit just to sharing and not let platform specify the exact IRQ flags it needs, defaulting to IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_SHARED? -- Dmitry