Re: [PATCH][RFC] input: remove bios I8042_CTR_XLATE check to make keyboard usable
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2009-10-28 05:43:12
Also in:
lkml
Hi Dave, On Tue, Oct 27, 2009 at 01:34:04PM +0800, Dave Young wrote:
Pressing somekey at early booting phase cause keyboard to be not usable (The hardware is DELL latitude e5400): atkbd.c: Unknown key pressed (raw set 2, code 0xd3 on isa0060/serio0). atkbd.c: Use 'setkeycodes e053 <keycode>' to make it known. atkbd.c: Unknown key pressed (raw set 2, code 0x1d3 on isa0060/serio0). atkbd.c: Use 'setkeycodes e053 <keycode>' to make it known. i8042.c set i8042_direct to true when the controller init. But the result is keyboard not usable, The only option is press the power button to shutdown. So here remove the bios check to fix it.
I would be a little hesitant to force translation by default on all architectures, although it may make sense on x86... Vojtech, you wrote the thing, do you see any issues with forcing translation? I think most of the x86 boxes work in translated mode and the only time it is in raw is when BIOS screwed up initialization.
quoted hunk ↗ jump to hunk
Signed-off-by: Dave Young <redacted> --- drivers/input/serio/i8042.c | 8 -------- 1 file changed, 8 deletions(-)--- linux-2.6.orig/drivers/input/serio/i8042.c 2009-10-13 08:57:07.000000000 +0800 +++ linux-2.6/drivers/input/serio/i8042.c 2009-10-27 13:15:13.000000000 +0800@@ -869,14 +869,6 @@ static int i8042_controller_init(void) spin_unlock_irqrestore(&i8042_lock, flags); /* - * If the chip is configured into nontranslated mode by the BIOS, don't - * bother enabling translating and be happy. - */ - - if (~i8042_ctr & I8042_CTR_XLATE) - i8042_direct = true; - -/* * Set nontranslated mode for the kbd interface if requested by an option. * After this the kbd interface becomes a simple serial in/out, like the aux * interface is. We don't do this by default, since it can confuse notebook
-- Dmitry