Thread (7 messages) 7 messages, 3 authors, 2009-09-15

Re: [PATCH] Input: bcm5974.c initialize raw_w, raw_x and raw_y before it get used

From: Henrik Rydberg <rydberg@bitmath.org>
Date: 2009-09-15 11:23:53

Jaswinder Singh Rajput wrote:
Hello Henrik,

On Sun, 2009-09-13 at 13:39 +0200, Henrik Rydberg wrote:
quoted
Jaswinder Singh Rajput wrote:
quoted
On Sun, 2009-09-13 at 01:24 +0200, Henrik Rydberg wrote:
quoted
Jaswinder Singh Rajput wrote:
quoted
raw_w, raw_x and raw_y is used uninitialized for !raw_n
Thanks for the heads up, but actually not, since !raw_n also implies
!(ptest > PRESSURE_LOW).
Then can we move 'if (ptest > PRESSURE_LOW && origin)' stuff to 'if
(raw_n)'. If not then my patch is correct.
Yes, that's it, thanks. So this patch ought to solve the warning cleanly:
hmm, even then there is room for improvement and save some cpu cycles :
Thanks, ill keep this one in reserve.

Henrik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help