Thread (4 messages) 4 messages, 3 authors, 2009-09-09

Re: [PATCH v2]add analog devices AD714Xcaptouch input driver

From: Mike Frysinger <hidden>
Date: 2009-09-09 06:05:58

On Tue, Sep 8, 2009 at 23:33, Song, Barry wrote:
+static inline int ad714x_spi_register_driver(struct spi_driver *spi_drv)
+{
+       return spi_register_driver(spi_drv);
+}
+
+static inline void ad714x_spi_unregister_driver(struct spi_driver *spi_drv)
+{
+       spi_unregister_driver(spi_drv);
+}
+
+#else
+#define ad714x_spi_register_driver(p) 0
+#define ad714x_spi_unregister_driver(p)
 #endif
i dont think you need the ifdef protection that far up.  what about
using the ifdef in this one place:
static inline int ad714x_spi_register_driver(struct spi_driver *spi_drv)
{
#if defined(CONFIG_SPI) || defined(CONFIG_SPI_MODULE)
    return spi_register_driver(spi_drv);
#else
    return 0;
#endif
}

then i imagine you can have all the other pieces always enabled.  gcc
will see that everything is marked static and not used, so it'll cull
things.
-mike
_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel@blackfin.uclinux.org
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help