-----Original Message-----
From: uclinux-dist-devel-bounces@blackfin.uclinux.org 
[mailto:uclinux-dist-devel-bounces@blackfin.uclinux.org] On 
Behalf Of Mike Frysinger
Sent: Wednesday, September 02, 2009 2:41 AM
To: Barry Song
Cc: dbrownell@users.sourceforge.net; dtor@mail.ru; 
dmitry.torokhov@gmail.com; 
spi-devel-general@lists.sourceforge.net; 
linux-input@vger.kernel.org; uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 1/2] add ad714x 
platform_datadefinition

On Mon, Aug 31, 2009 at 23:55, Barry Song[off-list ref] wrote:

quoted

--- /dev/null
+++ b/include/linux/spi/ad714x.h

@@ -0,0 +1,60 @@
+/*
+ * include/linux/ad714x.h
+ *
+ * AD714x is very flexible, it can be used as buttons, scrollwheel,
+ * slider, touchpad at the same time. That depends on the boards.
+ * The platform_data for the device's "struct device" holds this
+ * information.
+ */

missing lines:
* Copyright 2009 Analog Devices Inc.
*
* Licensed under the GPL-2 or later.

quoted

+#ifndef AD714X_HW_H
+#define AD714X_HW_H

header files should not be using an unprefixed name space (even if
it's an uncommon define name), and the name really should match the
header.  i.e. __LINUX_SPI_AD714X_H__

Fixed.

-mike
_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel@blackfin.uclinux.org
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel