On Thu 2009-07-30 13:00:40, Eric Miao wrote:

Pavel Machek wrote:

quoted

On Mon 2009-07-20 19:41:54, Eric Miao wrote:

quoted

Signed-off-by: Eric Miao <redacted>

Does this make some other driver obsolete? Should we disable the other
one or even remove it completely?

Yes, specifically the following two:

  drivers/input/keyboard/corgikbd.c
  drivers/input/keyboard/spitzkbd.c

which I don't feel quite comfortable since they are referencing the PXA
GPIO registers directly.

However, marking obsolete might be more smooth for the moment.

Given that there are unused/unsuable after your patch is applied,
removing them from build system is probably good first step.

quoted

quoted

 static struct platform_device spitzkbd_device = {
-	.name		= "spitz-keyboard",
+	.name		= "matrix-keypad",
 	.id		= -1,
+	.dev		= {
+		.platform_data = &spitzkbd_pdata,
+	},
 };

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html