M Marcel Holtmann #
Message details and related content
Hi Matthew,
quoted
actually if the key is clearly hardwired to WLAN, then it should not even show up as input event at all. This is one of the mis-concepts of the old RFKILL subsystem. No need to send an input event if the platform driver is going to rfkill that device anyway.There's still a policy decision. Does it kill internal devices, or does it kill all attached wlan devices?quoted
Remember that in the end it is just a key and whatever the user does with it is users policy. So in summary it is up to the platform driver to emit the proper key. For some it might be still KEY_WLAN, for other it might be KEY_RFKILL. Sounds fair?I agree on the technical side, but not the naming. KEY_WLAN is an rfkill-related key, so introducing KEY_RFKILL is potentially confusing. KEY_RFKILL_ALL isn't.
why is it confusing? I don't understanding your argument here. I think the KEY_RFKILL_ALL is confusing is the user policy then only kills WiFi devices or toggles between various on/off combinations. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html