Re: patch staging-htc-dream-touchscreen-driver-for-staging.patch added to gregkh-2.6 tree
From: Pavel Machek <hidden>
Date: 2009-07-28 11:16:27
From: Pavel Machek <hidden>
Date: 2009-07-28 11:16:27
Hi!
quoted
quoted
Don't see canceling timer nor shutting off WQ here. Also, maybe implement open() and close() so we don't reschedule WQ while polling?_)Unless you changed something there should be no failure path after starting the timer or enabling the interrupt. synaptics_ts_remove is missing a flush_work call though.
Can you submit patch to fix that?
quoted
2) it uses non-standard multitouch support. Either multitouch needs to be disabled for merge, or it needs to switch to standard config.I have a patch that adds support for the new protocol, but it does not yet remove the old hack.
Yes, such patch would be welcome. I guess we could wrap old, hacky protocol in ifdef, and then remove it when moving to drivers/input. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html