On Thu, Jul 23, 2009 at 03:25, Dmitry Torokhov wrote:

On Thu, Jul 23, 2009 at 02:46:11AM -0400, Mike Frysinger wrote:

quoted

On Thu, Jul 23, 2009 at 00:43, Dmitry Torokhov wrote:

quoted

On Tue, Jul 14, 2009 at 01:33:47PM -0400, Mike Frysinger wrote:

quoted

+struct platform_driver bfin_rotary_device_driver = {
+     .probe          = bfin_rotary_probe,
+     .remove         = __devexit_p(bfin_rotary_remove),
+     .suspend        = bfin_rotary_suspend,
+     .resume         = bfin_rotary_resume,

Need to use dev_pm_ops so platform code won;t yell at us.

looks like something new post 2.6.30 ... guess i'll have to keep this
in mind for migrating drivers when 2.6.31 comes out

quoted

I also think that this driver should too live in drivers/input/misc so I
moved it there. I did a bit of reshuffling in the patch, could you
please give it a try and if it still works I'll apply to the 'next'
branch.

could you toss like a standard dev_info("initialized") into the end of
bfin_rotary_probe ?  otherwise, builds and works fine for me with
2.6.31-rc4.  thanks!

Don't you find the boot to be too noisy? The input core already
prints a message when a new input device is registered...

you're right.  when i was testing, i didnt update my board resources
and so was seeing no output, so i added the dev_info() while also
fixing the resources.  didnt notice the additional input core output.
current behavior is fine then, thanks!
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html