Dear Dmitry,

Please see below.


Dmitry Torokhov:

On Thu, Jul 09, 2009 at 01:14:36PM +0800, Wan ZongShun wrote:

quoted

Dmitry Torokhov 写道:

quoted

Hi Wan,

On Thu, Jul 09, 2009 at 10:53:18AM +0800, Wan ZongShun wrote:

quoted

@@ -311,6 +309,9 @@ static int __devexit w90x900ts_remove(struct platform_device *pdev)
 	del_timer_sync(&w90p910_ts->timer);
 	iounmap(w90p910_ts->ts_reg);
 
+	clk_disable(w90p910_ts->clk);

This disable is unneeded since we already disable clock in close(). I
will fix locally and apply, there is no need to resubmit. I will also
fix pxa27 driver.

Okay, got it, thanks for your help!

Umm, one more thing - we need to add "depends on" to Kconfig since
clk API is not implemented on every platform. Any ideas what is the
most wide dependency is?

Do you mean that w90p910 ts have missed this "depends on"?
Adding this depends as following:

config TOUCHSCREEN_W90X900
	tristate "W90P910 touchscreen driver"
	depends on ARCH_W90X900
	help
	  Say Y here if you have a W90P910 based touchscreen.

	  To compile this driver as a module, choose M here: the
	  module will be called w90p910_ts.

Is it okay, now?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html