Thread (7 messages) 7 messages, 3 authors, 2009-06-17

Re: [PATCH] Restoring usages used by the pen.

From: Rafi Rubin <hidden>
Date: 2009-06-17 18:35:10

I did in fact submit a patch to linuxwacom a while ago specifically to solve that problem.

Perhaps in the long run a separate driver would be better.  But on the other hand, there is so much that is similar in the way the
devices behave and in the output we'd like from the driver, that it really seems a shame to have to fork or rewrite.


diff -r1.39 wcmUSB.c
510c510,511
< 	{ 0x9A, 2540, 2540, &usbTabletPC   }  /* TabletPC 0x9A */
---
	{ 0x9A, 2540, 2540, &usbTabletPC   },  /* TabletPC 0x9A */
	{ 0x1, 935, 1122, &usbTabletPC   }  /* TabletPC 0x9A */
529c530
< 	if (sID[1] == 0x056A)
---
	if (sID[1] == 0x056A || sID[1] == 0x1b96)
552c553
< 		if (common->tablet_id == 0x9A || common->tablet_id == 0x93 || common->tablet_id == 0x90)
---
		if (common->tablet_id == 0x9A || common->tablet_id == 0x93 || common->tablet_id == 0x90 || common->tablet_id==1)

Stéphane Chatty wrote:
Le 17 juin 09 à 04:39, Rafi Rubin a écrit :
quoted
Restoring usages used by the pen.

+
+        /* these are actually used by the pen */
+        case HID_DG_INVERT: /* high when the eraser button is pressed */
+        case HID_DG_ERASER: /* high when the tip and eraser are both
pressed */
+        case HID_DG_BARRELSWITCH:  /* doubtful */
+            return 0;
I just tested this on my multitouch-enabled Touchsmart tx2 (that is, one
on which the Windows 7 driver published by NTrig in March 2009 was
installed, which triggered a firmware install).

This is tricky:
 - as one can expect, the multitouch events are still emitted properly.
Fine.
 - but the Wacom Xorg driver patched by Rafi is not interested in the
device anymore. I had managed to emit touchscreen-like events for the
first finger detected on the screen, so as to feed Xorg with pointer
events. This does not work anymore. This probably has to do with the
complex rules that have been designed over time to decide what type of
device should be handled by what driver. I remember having to dig deep
in the code of hid, input *and* the Wacom driver last month to fit in
these rules.

TBH, this is not a big loss to me personally, because:
 - so far I had not been able to give the appropriate Xmax and Ymax
parameters to the Wacom Xorg driver, so the pointer was badly warped and
this was pretty useless anyway.
 -  at some point we'll probably want the NTrig digitizer to be managed
by another Xorg driver than the Wacom driver. Peter? Bryan? What do you
think?

I guess the whole issue is to try and understand what will be the most
popular uses of this device:
 - with which version of the firmware? the one with stylus and single
touch? the one with multitouch but no stylus?
 - as a touch screen? as a pen computer?

Leaving aside the pain of having incompatible versions of the firmware
around, it looks this type of dual device (stylus + finger) challenges
the way linux-hid, linux-input and Xorg regard touch devices: yes,
something that looks like a touchscreen can be a digitizer too... Maybe
we should create two Linux devices, one for the stylus and one for fingers?


-- 
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help