Re: [PATCH 2/2] tsc2007: make platform callbacks optional
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2009-06-25 21:23:59
Also in:
lkml
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2009-06-25 21:23:59
Also in:
lkml
On Tue, 23 Jun 2009 13:54:54 +0200 Richard R__jfors [off-list ref] wrote:
The platform callbacks are only called if supplied. Makes the driver to fallback on only pressure calculation to decide when the pen is up.
Again, I don't understand the reason for the change from the above description. Is there some driver in the tree which does not implement ->get_pendown_state()? If so, it will oops, won't it? Which driver is that? Or is there some other driver which you're developing which does not implement ->get_pendown_state()? If the latter, why should the problem be solved in this way, rather than implementing an empty ->get_pendown_state() within that driver? etc. More details, please.