Thread (7 messages) 7 messages, 3 authors, 2009-05-20

Re: [PATCH] input: add driver for EETI touchpanels [v4]

From: Daniel Mack <hidden>
Date: 2009-05-16 17:32:30

Hi Jean,

thanks for your input.

On Sat, May 16, 2009 at 05:57:16PM +0200, Jean Delvare wrote:
quoted
+	struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
+	struct eeti_ts_priv *priv;
+	struct input_dev *input;
+	int err = -ENOMEM;
+
+	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
This functionality does not correspond to the I2C access method your
code uses. You must check for I2C_FUNC_I2C instead (if you want to
check at all - it's essentially optional with the new binding model.)
Yes, I though so too and removed the check for now.
New version coming up.

Thanks,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help