Re: [patch 3/9] input: ads7846.c sparse lock annotation
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2009-05-14 03:24:16
On Tue, May 12, 2009 at 01:43:06PM -0700, akpm@linux-foundation.org wrote:
quoted hunk ↗ jump to hunk
From: Harvey Harrison <redacted> Signed-off-by: Harvey Harrison <redacted> Cc: Dmitry Torokhov <redacted> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/input/touchscreen/ads7846.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/input/touchscreen/ads7846.c~input-ads7846c-sparse-lock-annotation drivers/input/touchscreen/ads7846.c--- a/drivers/input/touchscreen/ads7846.c~input-ads7846c-sparse-lock-annotation +++ a/drivers/input/touchscreen/ads7846.c@@ -769,6 +769,8 @@ static irqreturn_t ads7846_irq(int irq, /* Must be called with ts->lock held */ static void ads7846_disable(struct ads7846 *ts) +__releases(&ts->lock) +__acquires(&ts->lock) {
I still haven't gotten any explanation why this is needed and also I am still getting sparce warnings with this patch applied. Please drop. -- Dmitry