Re: [PATCH] hid: add force feedback support for SmartJoy PLUS PS2/USB adapter
From: Jiri Kosina <hidden>
Date: 2009-05-11 15:17:05
On Fri, 8 May 2009, Jussi Kivilinna wrote:
This driver adds force feedback support for SmartJoy PLUS PS2/USB adapter. I made this driver one device spesific instead of making generic 'wisegroup-ff' because I have another Wisegroup PS2/USB adapter that doesn't work same way as SmartJoy PLUS. If another device that is compatible pops up, this driver could be then renamed to something more generic.
Thanks for writing the driver!
quoted hunk ↗ jump to hunk
--- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c@@ -1312,6 +1312,9 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) }, { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) }, +#if defined(CONFIG_SMARTJOYPLUS_FF) || defined(CONFIG_SMARTJOYPLUS_FF_MODULE) + { HID_USB_DEVICE(USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_SMARTJOY_PLUS) }, +#endif { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
Hmm, this isn't really compatible with what we have for other drivers, we require the config option to be turned on in order to have support (i.e. we include them into hid_blacklist unconditionally). Otherwise the driver looks OK. Jiri, what do you think? Thanks, -- Jiri Kosina SUSE Labs