On Tue, Mar 03, 2009 at 12:52:00AM -0800, Dmitry Torokhov wrote:

Hi Daniel,

On Mon, Mar 02, 2009 at 03:43:08PM +0100, Daniel Mack wrote:

quoted

On Fri, Feb 27, 2009 at 03:15:23PM -0500, hartleys wrote:

quoted

Not sure if it matters but you can add my Tested-by if you like.

Tested-by: H Hartley Sweeten <hsweeten@visionengravers.com>

quoted

quoted

I have a minor patch to it that allows the platform init to
configure the absolute/relative axis to report the encoder on.
If you would like to see it I can put together a patch.

Yes, and probably just post it as follow-up as soon as this one
has been commited. I'm new to this list, so I don't know who
can/will/wants to do this?

Dmitry Torokhov is listed as the maintainer of the input drivers.  I
think he needs to Ack the driver in order for it to be accepted and then
committed to the kernel.

Dmitry, are you willing to take this patch? Just wanted to make sure
it's not getting lost :)

I am willing, however I would like you to change it so you call
input_unregister_device() instead of input_free_device() in cases
when input device was successfully registered with the input core.
When input_register_device() fails (or if it wasn't invoked) then
you should call input_free_device().

Thanks!

BTW, you should probably make the axis configurable via platform data
instead of hardcoding it to ABS_X.

-- 
Dmitry