Re: [PATCH] input/joystick: add driver fortius 1942
From: Greg KH <hidden>
Date: 2009-03-17 02:27:14
Also in:
lkml
On Tue, Mar 17, 2009 at 03:21:18AM +0100, Peta Blaha wrote:
quoted hunk ↗ jump to hunk
Driver for Fortius 1942 device. Signed-off-by: Petr Blaha <redacted> ------ a/drivers/input/joystick/fortius_1942.c.orig 1970-01-0101:00:00.000000000 +0100
Your patch is linewrapped :(
quoted hunk ↗ jump to hunk
+++ b/drivers/input/joystick/fortius_1942.c 2009-03-17 03:17:01.000000000 +0100@@ -0,0 +1,394 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version.
Are you sure about "any later version"?
+ unsigned long difference = 0; + /*time measure*/ + struct timeval time, time_before; + /*guessed fastest speed a man can possibly ride-incitating full + throttle*/ + unsigned int fastest_wheel_rotate = 1000; + /*actual state of path reached in one cycle*/ + unsigned int ride = 0, old_ride = 0;
These should all be static. Have you run your code through scripts/checkpatch.pl?
+struct usb_tfor {
+ char name[128];Tabs are eaten by your email client :( Care to try again? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html