Re: [PATCH] Input notifier support
From: Trilok Soni <hidden>
Date: 2009-02-26 07:02:18
Also in:
lkml
Hi Kyungmin,
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/input.c b/drivers/input/input.c index 1730d73..7e96635 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c@@ -274,6 +274,8 @@ void input_event(struct input_dev *dev,add_input_randomness(type, code, value); input_handle_event(dev, type, code, value); spin_unlock_irqrestore(&dev->event_lock, flags); + if (type == EV_KEY) + input_notifier_call_chain(value, &code);
This check will be done for every input_report_xxx calls, even for touchscreen events (in which case of course it will fail), and I don't think this is optimal solution. Users should be given an option to disable this if they don't need this notification mechanism. How about moving this to input_report_key? -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html