Hi Felipe,

On Sat, Feb 21, 2009 at 4:22 AM, Felipe Balbi [off-list ref] wrote:

On Sat, Feb 21, 2009 at 12:29:12AM +0200, Felipe Balbi wrote:

quoted

On Fri, Feb 20, 2009 at 02:15:05PM -0800, Andrew Morton wrote:

quoted

On Thu, 19 Feb 2009 14:31:17 +0200
Felipe Balbi [off-list ref] wrote:

quoted

+struct lm8323_platform_data {
+ int debounce_time; /* Time to watch for key bouncing, in ms. */
+ int active_time; /* Idle time until sleep, in ms. */
+
+ int size_x;
+ int size_y;
+ int repeat : 1;

lm8323_platform_data.repeat appears to be never-written-to?

Nobody is using that yet, still it's used in the driver:
      if (pdata->repeat)
              __set_bit(EV_REP, idev->evbit);

Thanks for addressing my review comments to this patch and of course Andrew's.

Happy to add

Reviewed-by: Trilok Soni <redacted>

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni